Skip to content

Report WNEGCONSTCOMP also on smaller unsigned int types#216

Open
mandolaerik wants to merge 1 commit into
intel:mainfrom
mandolaerik:pr/report-wnegconstcomp-also-on-smaller-unsigned-int-types
Open

Report WNEGCONSTCOMP also on smaller unsigned int types#216
mandolaerik wants to merge 1 commit into
intel:mainfrom
mandolaerik:pr/report-wnegconstcomp-also-on-smaller-unsigned-int-types

Conversation

@mandolaerik

Copy link
Copy Markdown
Contributor

No description provided.

@mandolaerik

Copy link
Copy Markdown
Contributor Author

This check would have captured a $this == -1 check in PCI common code, which took me some effort to track down.

@syssimics

Copy link
Copy Markdown
Contributor

Verification #12268239: pass

@mandolaerik

Copy link
Copy Markdown
Contributor Author

We could also extend the check further, to warn for < 0 and >= 0

@lwaern-intel

lwaern-intel commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

@mandolaerik oh this is awkward

uhh... I guess you can close this? Or pick it if you prefer the way it goes about it.

@mandolaerik

Copy link
Copy Markdown
Contributor Author

Right, duplicates #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants