feat: added support for v26#2524
Draft
aryamohanan wants to merge 8 commits intomainfrom
Draft
Conversation
Contributor
Author
|
Currently the prebuilds are not working: This seems to be due to NAN (Native Abstractions for Node.js) not supporting Node.js v26 yet. See: https://github.com/nodejs/nan#native-abstractions-for-nodejs The current NAN version 2.26.2 only supports Node.js up to version 25. Node.js v26 introduced breaking changes in the V8 API that are incompatible with NAN. The gc-stats also filing on npm install step, because of the nan. I've created an issue here nodejs/nan#1017 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Tasks
ref https://jsw.ibm.com/browse/INSTA-80071
Issues
Node.js comes with V8 14.6 and some breaking changes. There asre two PRs to support Node.js on Nan and node-gyp:
Also yargs v17 also not compatible with v26
Let's wait for the v26 fixes