Repository navigation
Render v5: open detached-sound stories; speed lengths from range (#408) - #161
Merged
Merged
Conversation
…length from range (#408) - validateProject accepted only coupled generated tracks (shotId + offset 0), so a story with a detached clip sound (detached:true, shotId '', absolute offset) failed to open or save. Detached tracks are now valid; coupled tracks keep their rule. - A speed binding's length now always comes from its range and rate, as the exporter derives it, even when shot.seconds are stale (API edits) or the file is unreadable. chapterTiming uses the same, so sound placement matches the picture. Found opening Codex's #408 CPU fixture on staging: it failed to open, then showed 8.0 s instead of the exported 9.0 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects found during the #408 browser acceptance on Codex's fixture
qa408-cpu-v5-20261022:validateProjectrejected a detached generated track, so the story could not open ('could not be validated'). My own Detach button would have produced an unsavable story too.secondswhen the file was unreadable, so it showed 8.0 s instead of the exported 9.0 s.chapterTimingalso usedseconds, so sound placement could drift.Fix plus regression tests (full validateProject after detach; stale seconds + unreadable file → 96/24/96 frames, 0–4–5–9 s). Verified locally against staging: the fixture opens, shows 9.0 s (4.0 + 1.0 + 4.0) and 0.5 s blend, and the fixture version is unchanged (3). npm test 870 pass.
🤖 Generated with Claude Code