test: fix public mirror baseline assumptions#361
Closed
icatw wants to merge 1 commit into
Closed
Conversation
|
|
icatw
force-pushed
the
fix/test-baseline-public-mirror
branch
from
f511c08 to
1fb0809
Compare
|
Your change is now on Because this repository is maintained through an internal mirror, GitHub shows this PR as closed rather than merged, but your commits are on the default branch with your attribution intact. Closing it here to keep things in sync. |
|
This pull request has been automatically marked as stale because it has not had recent activity. If this PR is still relevant:
Thank you for your contributions! |
inkeep-oss-sync Bot
pushed a commit
that referenced
this pull request
Jul 7, 2026
Co-authored-by: Inkeep Public PR Bridge <public-pr-bridge@inkeep.com> Co-authored-by: icatw <99238504+icatw@users.noreply.github.com> GitOrigin-RevId: 09ab4c23e32dc3b07a9002a5daf6fe3e1f0dfa95
inkeep-oss-sync Bot
added a commit
that referenced
this pull request
Jul 7, 2026
GitOrigin-RevId: 09ab4c23e32dc3b07a9002a5daf6fe3e1f0dfa95
inkeep-oss-sync Bot
pushed a commit
that referenced
this pull request
Jul 7, 2026
* docs(specs): external-contribution baseline hardening spec * fix(desktop): keep bun install green without a C toolchain node-pty moves to optionalDependencies: its node-gyp build needs make/g++/python3 that Linux contributors to this macOS-only app may not have, and bun drops a failed optional install cleanly instead of failing the whole repo install. puppeteer (transitive via memlab, used only by the engineer-local tiptap leak probe) skips its ~600 MB Chrome-for-Testing download at install via the root package.json puppeteer key; the download taxes every fresh install and fails nondeterministically on linux-arm64. Container-verified: fresh toolchain-less arm64 install goes from exit 1 to exit 0; macOS keeps a working pty.node. * test(server): lift the blanket CI skip on sync-engine tests The file-wide process.env.CI skip was a workaround for oven-sh/bun#11892 (child reaping on GitHub-hosted runners). Validation now runs on Blacksmith runners and the bare-remote fixtures pin their branch since #361, so the suite passes under CI's master-default git. Verified 3x stable at ~12s per run on Linux under init.defaultBranch=master, and CI=1 locally runs 72 tests with 0 skips. * ci(ok-mirror): run server production guards against the materialized export New server-guards leg in check-ok-mirror-runnable.mjs runs bun test on the export's packages/server/scripts. These tests assert the published tree's shape, the one class an internal checkout can never catch because the internal tree always has the files the mirror transform excludes. #361 is the motivating incident: the skills _shared dir held only a README internally, the manifest's README exclude emptied it on export, and the guard failed on every public clone with no CI surface seeing it. Deliberately narrow (no server boot, no D-Bus surface, 20 tests in 35ms) per the runnability report's full-matrix decision. Same retry, timeout, and false-green discipline as the core-tests leg. Verified end-to-end green plus a negative control: reverting the guard on an export copy fails the leg. * test(desktop): pin node-pty packaging guard to optionalDependencies placement The guard asserted node-pty lives in dependencies so electron-builder packs it. Placement moved to optionalDependencies so a failed native build no longer fails bun install on toolchain-less machines. Packing verified against a real build:dir package: app.asar.unpacked/node_modules/node-pty/prebuilds/ ships in the .app. The guard now pins the optional placement in both directions (present + pinned there, absent from dependencies) and keeps the @lydell/node-pty exclusion. * test(server): point the lifted CI-skip comment at the class follow-up issue The remaining 17 files with the blanket process.env.CI gate are tracked in issue #2447 with the per-file evidence bar. * test(ok-mirror): pin the server-guards leg wiring in the runnability gate Same source-pin style as the existing puppeteer install-leg tests, with the same fail-loud region isolation: the leg must run bun test scripts/ in the export's packages/server, retry only plain failures (never timeouts), and keep the zero-tests false-green guard. * fixup! local-review: address findings (pass 1) * docs: address cloud review comment-quality findings Update the runnability LAYERS header for the second L3 leg, drop the private-repo issue link from the public-mirrored sync-engine comment (the 17-file blanket-CI-skip class and its per-file evidence bar stay tracked in inkeep/agents-private#2447), restate that comment as standing rationale instead of dated change narration, and mend a reflowed sentence in the runnability test docblock. GitOrigin-RevId: 28e4801b85121ece5ee93d5d902e0256a393f332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HEADatmainbefore cloning._sharedonly when source bundles still reference shared placeholders.Verification
bun test packages/server/src/sync-engine.test.ts --test-name-pattern 'SyncEngine ConflictStore admission'3 pass / 0 failbun test packages/server/scripts/build-skill-bundles.test.ts --test-name-pattern 'repo assets'7 pass / 0 failVerification screenshot:
Full-repo check note
This PR fixes two reproducible public-mirror baseline failures.
bun run checkis still blocked separately byoxlint@1.66.0panicking withcalled Result::unwrap() on an Err value/SIGABRTunder the repo's currentoxlint.config.ts.