Skip to content

chore: improve error display #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fraser999 merged 1 commit into from
Jun 18, 2026
+15 −2
Merged

chore: improve error display #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,12 @@ pub enum MdbxError {
/// Permission defined
#[error("permission denied to setup database")]
Permission,
/// Unknown error code.
#[error("unknown error code: {0}")]
/// An error code MDBX did not map to a specific variant.
///
/// MDBX's own codes are negative; a positive code is a system `errno` (e.g. `ENOSPC` or
/// `EDQUOT`) that MDBX passed through unchanged, so it is rendered with its OS description
/// rather than a bare number.
#[error("{}", fmt_other_code(*.0))]
Other(i32),
/// Operation requires DUP_SORT flag on database.
#[error("operation requires DUP_SORT flag on database")]
Expand All @@ -193,6 +197,15 @@ pub enum MdbxError {
SnapshotDivergence,
}

// Positive codes are system errnos rendered via the OS; negatives are unrecognised MDBX codes.
fn fmt_other_code(code: i32) -> String {
if code > 0 {
std::io::Error::from_raw_os_error(code).to_string()
} else {
format!("unknown MDBX error code: {code}")
}
}

impl MdbxError {
/// Converts a raw error code to an [`MdbxError`].
pub const fn from_err_code(err_code: c_int) -> Self {
Expand Down