Copy domains list when creating kernels in realize_reduction

[majosm]

Avoids accidental mutation of kernel.domains from sharing of domains list reference between kernel and red_realize_ctx.

[alexfikl]

I think I touched some of this last year when doing some typing changes. Wasn't the idea to move more towards making these immutable? i.e. domains are a Sequence so that they can accept a tuple?

[inducer]

I think I touched some of this last year when doing some typing changes. Wasn't the idea to move more towards making these immutable? i.e. domains are a Sequence so that they can accept a tuple?

That'd be nice. I suppose typing could help enforce this. (Though we'd probably have to tighten the type to tuple, at least briefly for development.)

[alexfikl]

That'd be nice. I suppose typing could help enforce this. (Though we'd probably have to tighten the type to tuple, at least briefly for development.)

Also that would be a pretty breaking change, in case any downstreams expect it to be mutable. Anyways, that's a bigger change, maybe not for this PR 😁

[inducer]

Also that would be a pretty breaking change, in case any downstreams expect it to be mutable. Anyways, that's a bigger change, maybe not for this PR 😁

Not really! The data structure was always notionally immutable, just not factually so.