Change build_insn_group to use a loop instead of recursion for successive groups#1030
Merged
Merged
Conversation
Contributor
Author
|
Note: this is easier to read with |
inducer
approved these changes
Jul 24, 2026
inducer
force-pushed
the
build-insn-group-loop
branch
from
July 24, 2026 15:31
fe42619 to
f735e46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally added this change in order to make it easier to read the profiler output, but it turned out to have an impact on performance in its own right. 🤷♂️
This is another one of the optimizations shown in the plot in #1026.