Avoid copying kernels repeatedly in duplicate_inames/rename_inames_in_batch#1028
Merged
Conversation
inducer
reviewed
Jul 24, 2026
inducer
left a comment
inducer
left a comment
Owner
There was a problem hiding this comment.
I like the idea, but the singulars should just be simple wrappers of the plurals.
majosm
force-pushed
the
rename-inames-multi
branch
2 times, most recently
from
July 24, 2026 16:58
252f376 to
3a7e38f
Compare
majosm
force-pushed
the
rename-inames-multi
branch
from
July 24, 2026 20:30
3a7e38f to
484f4d1
Compare
inducer
enabled auto-merge (rebase)
July 24, 2026 20:52
Owner
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
MultiDomainChangerto avoid excessive kernel copies induplicate_inames. Also addsrename_inames_multito do the same forrename_inames_in_batch.This is another one of the optimizations shown in the plot in #1026.