Repository navigation
fix(deploy): use sandboxd resources and correct node dashboard - #111
Conversation
Keep the E2E guide focused on current coverage, listener ports, recovery requirements and cleanup checks. Place the tunnel policy group alongside the other network tests. Signed-off-by: robbluo <luo1442@gmail.com>
Use the outer join mode for the nine node status queries so Grafana 11.5.2 aligns all values by node_key without repeated sparse rows. Persist the fix in the monitor chart dashboard, matching agent-dx PR inclusionAI#88. Signed-off-by: robbluo <luo1442@gmail.com>
Connect adxlet to the sandboxd resource socket shared by the Kubernetes, Aliyun and Huawei Cloud deployment profiles. This uses the Kubernetes resource provider and sandboxd device inventory for scheduling capacity. Validate the rendered adxlet socket against sandboxd in all three profiles and document the resource collection contract. Signed-off-by: robbluo <luo1442@gmail.com>
There was a problem hiding this comment.
Correction: the previously raised zero-capacity case follows an existing documented ADX TTL fallback, whose implementation predates this PR. I withdraw the initial merge-blocking P2 recommendation. Local reproduction and optional policy refinement are tracked separately in #113 (#113); no new regression or RC blocker has been established. This remains a comment-only review, not approval. No merge, SDK publication or cluster upgrade was performed.
rcyw
left a comment
There was a problem hiding this comment.
Approved at 0159ab933561440f7fc19290d29162867801331c.
Using sandboxd's configured Kubernetes resource provider aligns adxlet's scheduling capacity and device inventory with the deployment configuration. The Grafana outer join is appropriate for these queries' unique (adx_env, node_id) keys and was verified against Grafana 11.5.2 behavior. The E2E documentation matches the current pinned tunnel coverage.
Validation: 38 local core chart/observability/resource checks and 3 Terraform contracts passed, core/monitor Helm lint passed, all 7 rendered dashboard JSON files parsed, and the nine-query join correctly produced one complete row per node while preserving missing metrics. The current GitHub test checks, including Standalone E2E, are successful. No new cloud deployment was performed for this review.
No remaining blocking findings. #113 separately tracks the existing zero-capacity/TTL policy boundary; the cache/expiry behavior predates this PR and is not a confirmed regression or a release prerequisite. My earlier merge-blocking recommendation has been withdrawn. This approval does not merge the PR or resume SDK publication or cluster upgrades.
Adxlet currently uses local
autoresource detection even though the Kubernetes, Aliyun and Huawei Cloud profiles enable sandboxd's Kubernetes resource provider. Read sandboxd's/resourceendpoint over/var/run/resource.sockso scheduling capacity and device inventory use the configured runtime provider. Add a rendered cross-profile socket contract and update deployment documentation.Also fix the monitor chart's ADX node-status table for Grafana 11.5.2: change its nine-query join from
outerTabulartoouterto prevent repeated sparse node rows and incorrectUnknowncells. This matches openJiuwen-ai/agent-dx#88.The E2E guide now describes
network-tunnel-blockalongside the other network tests, retaining listener ports, policy transitions, the 10-second recovery requirement, blocked-service checks and cleanup requirements.Validation:
auto != sandboxd; after the fix, 40 focused checks passed (10 observability, 27 chart, 3 Terraform).git diff --checkpassed.Live deployment validation (resource-source change only):
akernel-corein namespaceakernelon cn-north-4akernel-cce, Helm revision 100 → 101. Retained the deployed image digest, reused existing release values, preserved control-role Pods, and limited worker rolling updates to one unavailable Pod.The monitor-dashboard change was validated by rendering and was not deployed in this cluster update. This run retained the existing binaries and does not establish a newly built image or Aliyun runtime validation.