Repository navigation
fix: snapshot the iteration range of optimised array searches - #1334
Merged
mweststrate merged 1 commit intoOct 20, 2026
Merged
Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
Collaborator
|
To be fair I think mutative predicates should be strictly forbidden 😅. But the patch is small enough to warrant including it. |
Contributor
|
🎉 This PR is included in version 11.1.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot the iteration length for the array-methods plugin's
findandfindLast, matching native array searches.Once a draft has a copy, a predicate can append or remove entries through the draft. The current loop then searches newly appended values or stops early when the array shrinks.
Three regressions fail with the plugin enabled and pass in the native-mode controls. All 3,377 base tests and the package build pass, including type declarations.