build(ci): key Playwright browser cache on .service-versions - #111
Open
iloveitaly wants to merge 1 commit into
Open
iloveitaly wants to merge 1 commit into
iloveitaly wants to merge 1 commit into
Conversation
Read the Playwright package version with jq from .service-versions instead of hashing uv.lock, so unrelated lockfile changes do not bust the browser cache. Co-authored-by: Michael Bianco <mike@mikebian.co>
iloveitaly
marked this pull request as ready for review
September 3, 2026 18:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Playwright browser cache was keyed on
hashFiles('uv.lock', '.service-versions'), which invalidates on any lockfile or service-version change. A more precise key is the Playwright package version itself, which is what determines the downloaded Chromium revision.This replaces lockfile scraping /
awkwith the samejq -rpattern already used for postgres injust/database.just.Description
playwrightin.service-versionsviawrite-versions(fromimportlib.metadata).jq -r '.playwright'and use it as theactions/cachekey.Screenshots / Test
Local verification:
jq -r '.playwright' .service-versionsreturns1.62.0, matching the installed Playwright package. The resulting cache key isLinux-playwright-1.62.0.Links