Update Fermi Catalog and adapt feature name in plotting function #88
Open
azegarelli wants to merge 5 commits into
Open
Update Fermi Catalog and adapt feature name in plotting function #88azegarelli wants to merge 5 commits into
azegarelli wants to merge 5 commits into
Conversation
Updated the catalog name to the latest version and commented out the previous name.
G-Sommani
approved these changes
Jun 9, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hi,
After the release of a new catalog by Fermi (https://fermi.gsfc.nasa.gov/ssc/data/access/lat/fl16y/), and after discussion among the Real-time group and ROC (@blaufuss ), we would like to change the catalog name in
skyreader/constants.py..In this way, the new FIT file (stored in
/cvmfs/icecube.opensciencegrid.org/users/azegarelli/realtime/catalogs) is used to produce zoomed plots around the track-alert reconstructions with Skymist.Consequently, I propose to change here
plot_4fgltoplot_fermi_sources, to make the boolean more general to the usage of every Fermi catalog name that can be changed inskyreader/constants.py..This implies also a similar change in SkyMist (see the following pull request https://github.com/icecube/skymist/pull/272)
We take profit of this merge request, to fix a failing check for mypy(>=3.11), appeared after January 2026 (
skyreader/skyreader/utils/handle_map_data.py
Lines 334 to 337 in 71de863