Skip to content

add 2 components version for GSF and H4a flux models #81

Merged
kjmeagher merged 7 commits into
mainfrom
2comp_IT_GSF
Jun 10, 2026
Merged

add 2 components version for GSF and H4a flux models #81
kjmeagher merged 7 commits into
mainfrom
2comp_IT_GSF

Conversation

@matthiasplum

Copy link
Copy Markdown
Contributor

Add a flux model for the IceTop 2 component datasets

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fbe0782) to head (41f85c7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          846       855    +9     
=========================================
+ Hits           846       855    +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Test Results

    9 files  ± 0      9 suites  ±0   2m 54s ⏱️ -8s
  576 tests + 4    363 ✅ + 4    213 💤 ±0  0 ❌ ±0 
5 184 runs  +36  3 267 ✅ +36  1 917 💤 ±0  0 ❌ ±0 

Results for commit 41f85c7. ± Comparison against base commit fbe0782.

♻️ This comment has been updated with latest results.

@kjmeagher

Copy link
Copy Markdown
Member

I renamed the new model to simply GlobalSplineFit2Comp since the _IT suffix is code for 4 component model. added it to the tests to get the coverage up to 100% and sorted the all statement

matthiasplum and others added 3 commits June 9, 2026 18:41
clearify the description for the GSF 2 component model
not sure how it wasnt
@kjmeagher kjmeagher merged commit ee8b435 into main Jun 10, 2026
16 checks passed
@kjmeagher kjmeagher deleted the 2comp_IT_GSF branch June 10, 2026 03:27
@matthiasplum matthiasplum changed the title gsf flux 2comp for IT add GSF and H4a flux for 2 components Jun 10, 2026
@matthiasplum matthiasplum changed the title add GSF and H4a flux for 2 components add 2 components version for GSF and H4a flux models Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants