Enhancements/multisample#67
Draft
christophra wants to merge 39 commits into
Draft
Conversation
…ultiple datasets, one first implementation for testing. Still several FIXMEs, no support for PriorFollowup, and want to try implementing it with more inheritance for tidier code, keeping the multi-dataset additions away from the single-dataset. Using skylab branch branches/chraab_multi_fra
…analysis information
…fit_ra, dec for PS
…aults from any user matplotlibrc
…GFU from /data/user/apizzuto to a GFU dataset which is still assumed to be GFUOnline_v001p02
…0, ns_scan at best-fit gamma (to be discussed), make upper limit plot state pivot energy if index not 2
…when introducing _single and _multi methods
…report for a MultiPointSourceFollowup, with fixed spectral index. Includes minor modifications to the FRA base class and ReportGenerator.
…dd llh_exp property to base class. Allow changing plot size while keeping circles to scale.
… pivot energy if index is floating
…it goes in the report table.
…y painlessly by adding iteration in base class similar to plot_skymap_zoom. Could keep that code more separate with refactoring, though.
…methods to attributes that child classes can change, eg because they use a different LLH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(draft PR just so it's on the radar)