Repository navigation
test(server): make host-dependent fixtures portable - #7
Merged
Merged
Conversation
iXab3r
marked this pull request as ready for review
November 1, 2026 11:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Host-dependent test fixtures cause 14 failures on Windows and one on macOS: JSON path escaping, an inherited platform, and temporary-directory aliases.
Change
Escape expected paths as JSON, pin the Linux fixture's platform, and canonicalize its filesystem paths.
Scope
Two existing server test files, +15/−6. No production code changes.
Addresses the baseline failures reported in #22552 (Windows) and #27001, #26967 (macOS). Related stability report: #22324; its separate failures are outside this PR.
Verification
Same command and dependencies per OS; Node 26.12.1, Vite Plus 1.4.0, Vitest 5.0.5.
vp test run apps/server/src/environment/ServerEnvironment.test.ts apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.tsf48df77f6f0eae6f0d53f7a4check:changedpassed: static checks and 286 tests, one skipped.Model and harness: GPT-6.1 Sol via Codex in T3 Code.