-
Notifications
You must be signed in to change notification settings - Fork 1
release: 0.39.0 #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
release: 0.39.0 #94
Changes from all commits
5f5049a
9ac7b35
dd48b06
48b1cfa
bc710fb
d978c9d
5157c9b
58ab502
d4b2496
6e78500
8a752b4
f6cdc59
0e3b514
72136b1
eb18d4a
43ec88d
cf52108
2fd5100
8f0033a
e842768
700d0af
f70b77d
6f8f5a6
e1f12f8
10386a3
9ccb5ff
cd47ae4
8958b49
f827fb4
d00e498
c522f18
e620b86
c31c296
1f3a018
bb51450
898829a
7465b15
4d34c7e
e94d053
274834b
eb85299
55cdd7c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,3 @@ dist-deno | |
| .eslintcache | ||
| dist-bundle | ||
| *.mcpb | ||
| oidc | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| ".": "0.38.0" | ||
| ".": "0.39.0" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| configured_endpoints: 30 | ||
| openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/hyperspell%2Fhyperspell-a4bf4f3aaf1509541db646bc9ff7ec58e78cb4d42cf6bf83881b02739ad77b87.yml | ||
| openapi_spec_hash: 89cd02b2290061877e6badcddb7c8eb8 | ||
| config_hash: 09bb5ca4418f316f95d2b75ef7399cf0 | ||
| openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/hyperspell/hyperspell-cec6507dd37a73b074fd57ef2cd54479cddf3d5efceab2d36b906485ed36ec86.yml | ||
| openapi_spec_hash: 58ed64e4179f15f76c7ca0cef2e68f03 | ||
| config_hash: 597eba5e5eaec83a5f0db3d946af8db5 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,7 @@ | |
|
|
||
| set -eux | ||
|
|
||
| if [[ ${NPM_TOKEN:-} ]]; then | ||
| npm config set '//registry.npmjs.org/:_authToken' "$NPM_TOKEN" | ||
| elif [[ ! ${ACTIONS_ID_TOKEN_REQUEST_TOKEN:-} ]]; then | ||
| echo "ERROR: NPM_TOKEN must be set if not running in a Github Action with id-token permission" | ||
| exit 1 | ||
| fi | ||
| npm config set '//registry.npmjs.org/:_authToken' "$NPM_TOKEN" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Prompt to fix with AI
|
||
|
|
||
| pnpm build | ||
| cd dist | ||
|
|
@@ -62,8 +57,5 @@ else | |
| TAG="latest" | ||
| fi | ||
|
|
||
| # Install OIDC compatible npm version | ||
| npm install --prefix ../oidc/ npm@11.6.2 | ||
|
|
||
| # Publish with the appropriate tag | ||
| pnpm publish --npm-path "$(cd ../ && pwd)/oidc/node_modules/.bin/npm" --no-git-checks --tag "$TAG" | ||
| pnpm publish --no-git-checks --tag "$TAG" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bin/publish-npmpreviously had an inline guard that printed a clear error and exited ifNPM_TOKENwas unset and OIDC was unavailable. The newbin/publish-npmdrops that guard entirely and unconditionally callsnpm config set ... "$NPM_TOKEN". The validation was moved tobin/check-release-environment(called only fromrelease-doctor.yml), butpublish-npm.ymlnever callscheck-release-environment. If either secret (HYPERSPELL_NPM_TOKEN/NPM_TOKEN) is missing, GitHub Actions resolves the expression to"", so the publish job builds all packages, installs deps, and then fails late atpnpm publishwith a cryptic npm auth error instead of the fast, descriptive message.Prompt to fix with AI