Repository navigation
fix(ci): delete ci-benchmarks.yml — never started, nothing to run - #128
Merged
Merged
Conversation
It called local workflows that lack `on: workflow_call` (startup failure on every run since at least 2026-10-04), and each of them already runs standalone. Its benchmark job read hyperpolymath/proven benchmarks/quandledb, which does not exist, and its Sonar job needed a SONARQUBE_TOKEN secret. Removed by owner ruling (2026-10-08); the workflow's actions.lock entry goes with it, dependency entries stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012kgrMQRhSmZMBbF9Ui1zBw
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (24)
|
| Layer / File(s) | Summary |
|---|---|
Remove benchmark CI workflow .github/workflows/ci-benchmarks.yml |
The workflow file is deleted, including its triggers, test and benchmark jobs, SonarQube analysis, and CodeQL and Dependabot calls. |
Priority: ➖ Normal
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Merge Risk: ⚪ Minimal · up to 0ea78
This removes a CI workflow that the author says never ran successfully. No actionable merge-blocking risk was identified.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Title check | ✅ Passed | The title clearly identifies the main change: deleting the unused ci-benchmarks workflow because it never started. |
| Description check | ✅ Passed | The description directly explains the workflow deletion, the reported startup failures, the reasons for removal, and the verification performed. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit found the workflow gone,
And hopped past tests at early dawn.
No nightly runs, no benchmark flight,
The YAML rests in moonlit night.
One twitching nose, one quiet cheer,
The carrots still are waiting here.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
.github/workflows/ci-benchmarks.yml. It has never started: the nightly run ended instartup_failure, and the 2026-10-08 push/PR runs infailurewith 0 jobs. Removed by owner ruling (2026-10-08).Why it is dead, not broken:
uses:./.github/workflows/{krl-verification,codeql,dependabot-automerge}.yml, none of which declareson: workflow_call. That is a startup error, and each already runs on its own triggers.hyperpolymath/provenbenchmarks/quandledb, which does not exist (proven/benchmarksholds only shared Idris benches).SONARQUBE_TOKENsecret.Closes #
No issue; this is the knot-rider twin (same cause, same ruling).
Type of change
📌 New pins
Head SHA: 0ea78e1
None added or changed; only the workflow's entry under
workflows:is removed fromactions.lock. Everydependencies:entry stays untouched.How has this been verified?
gh actions-lock --verify-local(v0.1.6, the lock gate's tool) on head → rc 0, "All 14 workflows have complete lockfile coverage". Base: 15 workflows, rc 0, the same pre-existingsha-as-refwarning.git grep ci-benchmarksmatched only the file and its lock entry.Checklist
%G?= G).Notes for reviewers
Census of 450 local clones: only quandledb and knot-rider carry this scaffold.
🤖 Generated with Claude Code
https://claude.ai/code/session_012kgrMQRhSmZMBbF9Ui1zBw