Repository navigation
chore(runtime): purge python and deno tooling; bun validator + ban check - #411
Merged
Merged
Conversation
- dogfood-gate: the eclexiaiser.toml check was a python3 tomllib heredoc. It is now scripts/validate-eclexiaiser.js (Bun.TOML), same four rejections and messages, plus a parse-error case; 7 bun tests. - dogfood-gate: new `Banned-runtime check` job runs `bun test scripts/` and scripts/ban-npm.sh; oven-sh/setup-bun@v2.2.0 (0c5077e, the pin standards already vets) added to actions.lock, scratch-relocked and checked with `gh actions-lock --no-fix --verify` (0 errors; a planted corrupted pin reports unreachable-pin). - scripts/ban-npm.sh: now fails on deno.json/deno.jsonc/deno.lock (it claimed deno was banned without checking); drops the Deno bare-import warning and the "Deno approved" text. 5 planted-fixture bun tests. - hooks/pre-commit (the core.hooksPath hook) runs ban-npm.sh first. - Delete .github/hooks/pre-commit (unreferenced; deno lint/check of a path that does not exist), .pre-commit-config.yaml (needs the Python pre-commit framework; hooks/ is the canonical hook set), and scripts/build-production.sh (builds src/rescript, which does not exist, via node_modules; referenced nowhere). - NOTICE: replace the deno.json dependency line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P48P9ErT8UFFeDUfEQiYV7
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Add Carrot credits or activate Agent usage billing to use Autopilot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the remaining python and deno tooling from echidna, and makes the banned-runtime check actually enforce what it claims. The eclexiaiser manifest check moves from a
python3tomllib heredoc to a tested bun script.scripts/ban-npm.shsaid deno was banned but never checked for it; it now does, under 5 planted-fixture tests.📌 New pins
actions.lockentry, plus a workflow entry underdogfood-gate.yml. It is the same SHA standards already vets. The lock diff against main is additive only.bun-version:, matchingmise.lock.Changes
dogfood-gate.yml/ eclexiaiser job: the python heredoc is replaced bybun scripts/validate-eclexiaiser.js, with the same four rejection messages plus a parse-error case.dogfood-gate.yml: a new Banned-runtime check job runsbun test scripts/andbash scripts/ban-npm.sh. It is added to the summary job'sneeds:.scripts/ban-npm.sh: now fails on anydeno.json,deno.jsoncordeno.lock. The Deno bare-import warning (which scanned a nonexistentsrc/provers/) and the "Deno approved" text are gone.hooks/pre-commit(thecore.hooksPathhook): runsban-npm.shbefore thejustcheck, so it runs even whenjustis missing..github/hooks/pre-commit: unreferenced; it ran deno lint/check on a path that does not exist..pre-commit-config.yaml: needs the Python pre-commit framework;hooks/is the canonical hook set.scripts/build-production.sh: builds the nonexistentsrc/rescriptvianode_modulesandpython3 -m http.server; referenced nowhere.NOTICE: thedeno.jsondependency line is replaced by the bun scripts line.RSR Quality Checklist
Required
bun test scripts/→ 12 pass, 0 fail. No Rust code changed, socargo testis not affected.actionlint dogfood-gate.ymlreports only the pre-existing SC2129/SC2295 findings, identical to main.unsafeblocks: no Rust touched.MPL-2.0)..envfiles.As Applicable
docs/decisions/: not applicable, not an architectural decision.ROADMAP.adoc: not applicable.NOTICEline above.TOPOLOGY.md: not applicable.oven-sh/setup-bunis MIT, CI-only, and not distributed.Testing
scripts/validate-eclexiaiser.test.js(7 tests) andscripts/ban-npm.test.js(5 tests) were each run RED before the implementation existed. The three deno cases failed before the check was added. Both now give 12 pass / 0 fail.bun scripts/validate-eclexiaiser.js eclexiaiser.tomlexits 0 on the repo manifest and 1 on a broken one.gh actions-lock --no-fix --verify --json=valid,findingsreportsvalid: true, 0 errors, and 1 warning (cicd-suite@4c772eb sha-as-ref, from ci: pin cicd-suite, dtolnay/rust-toolchain and the Hypatia clone (#401) #410; cicd-suite has no tags).--no-narrow --no-migrate-local-actions --no-interactive. Write mode was never run in the repo.unreachable-pin.grep -c python dogfood-gate.ymlgives 0.Out of scope, recorded as findings rather than changed here:
echidna-playground/src/PlaygroundServer.affinestill drivesdeno serve/deno task.🤖 Generated with Claude Code
https://claude.ai/code/session_01P48P9ErT8UFFeDUfEQiYV7