[Repo] Port editors/vscode/src/extension.ts to .affine once #35 lands #63

Activity

1. hyperpolymath

   added a commit that references this issue on May 11, 2026

   feat: typed-wasm xmod + Node backend + extern + VS Code (#35, #42) (#90)

   ...

   d126286
2. hyperpolymath commented on May 15, 2026

   

   hyperpolymath

   on May 15, 2026 – with Claude

   OwnerAuthor

   More actions

   This appears effectively complete — flagging for closure confirmation (not self-closing, per the ISSUE-CLOSURE rule).

   Acceptance-criteria status:

   • Add Node-target backend + vscode-API bindings to enable .affine VS Code extensions #35 landed — Node-CJS codegen (lib/codegen_node.ml) produces a require()-able CJS module; Codegen: --vscode-extension flag to inline extraImports wiring #105/Codegen: --vscode-extension flag to inline extraImports wiring #116 added --vscode-extension to inline the adapter wiring.
   • Ported — editors/vscode/src/extension.ts is gone; source of truth is editors/vscode/src/extension.affine.
   • main updated — editors/vscode/package.json main → ./out/extension.cjs, and its compile script now passes --vscode-extension (Codegen: --vscode-extension flag to inline extraImports wiring #116).
   • Exemption row removed — .claude/CLAUDE.md lists editors/vscode/src/extension.ts under Closed exemptions (closed 2026-05-03), with tools/check-no-extension-ts.sh guarding regressions (wired into just check + CI).
   • End-to-end activation/LSP/disposable verification — the only item not mechanically provable from the tree. The --vscode-extension wiring is what makes the Vscode/VscodeLanguageClient imports actually resolve at activation; full in-editor verification would need a live VS Code host.

   Everything except the live-host smoke test is done. @hyperpolymath — OK to close this (tracking any remaining in-editor verification under the #104 publish work / a dedicated QA pass), or would you like the e2e verification tracked here before closing?

   ---

   Generated by Claude Code
3. hyperpolymath

   self-assigned this

   on May 16, 2026
4. hyperpolymath commented on May 16, 2026

   

   hyperpolymath

   on May 16, 2026 – with Claude

   OwnerAuthor

   More actions

   Closing as completed at owner request.

   All mechanically-verifiable acceptance criteria are met:

   • Add Node-target backend + vscode-API bindings to enable .affine VS Code extensions #35 landed — lib/codegen_node.ml Node-CJS codegen + --vscode-extension wiring (feat: typed-wasm xmod + Node backend + extern + VS Code (#35, #42) #90, Codegen: --vscode-extension flag to inline extraImports wiring #116); Add Node-target backend + vscode-API bindings to enable .affine VS Code extensions #35 closed completed 2026-05-11.
   • Ported — editors/vscode/src/extension.ts removed; source of truth is editors/vscode/src/extension.affine.
   • main updated — editors/vscode/package.json main → ./out/extension.cjs.
   • Exemption row removed — listed under Closed exemptions in .claude/CLAUDE.md (closed 2026-05-03), regression-guarded by tools/check-no-extension-ts.sh (wired into just check + CI).

   The remaining acceptance item — live-host activation / command / LSP / disposable verification — cannot be proven from the repo tree and is now tracked separately in #139 (to be folded into the #104 publish QA pass).

   ---

   Generated by Claude Code
5. hyperpolymath

   closed this as completedon May 16, 2026