Expose filesystem limits in .NET SDK - #215
Open
jsturtevant wants to merge 1 commit into
Open
Conversation
jsturtevant
force-pushed
the
filesystem-limits-dotnet
branch
from
September 10, 2026 00:08
cf77cf8 to
ed68b5d
Compare
jsturtevant
added this pull request to stack #216
September 10, 2026 00:12
There was a problem hiding this comment.
🟡 Changes recommended
The last-policy-wins test does not verify observable quota behavior or forwarding to native code.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Exposes writable filesystem quota configuration through the .NET SDK and Rust FFI.
Changes:
- Adds finite and unlimited filesystem-limit builder APIs.
- Passes quota policies through P/Invoke to both sandbox backends.
- Adds builder and native validation tests.
File summaries
| File | Description |
|---|---|
src/sdk/dotnet/ffi/src/lib.rs |
Implements native quota configuration and validation. |
SandboxBuilderTests.cs |
Tests builder configuration flows. |
PInvokeLayerTests.cs |
Tests filesystem-limit native calls. |
SafeNativeMethods.cs |
Declares the new P/Invoke function. |
SandboxBuilder.cs |
Adds public filesystem-limit builder methods. |
Sandbox.cs |
Applies limits during sandbox construction. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
force-pushed
the
filesystem-limits-dotnet
branch
from
September 11, 2026 19:00
ed68b5d to
fd25c96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose writable filesystem limit configuration through the .NET builder and native FFI, including validation and builder/PInvoke tests.
Stacked on #214 (and therefore #213).