fix: remove release_max_level_error tracing feature from hyperlight-js-runtime#128
Open
jprendes wants to merge 1 commit intohyperlight-dev:mainfrom
Open
fix: remove release_max_level_error tracing feature from hyperlight-js-runtime#128jprendes wants to merge 1 commit intohyperlight-dev:mainfrom
release_max_level_error tracing feature from hyperlight-js-runtime#128jprendes wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
mattmccreesh
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
release_max_level_errorfeature from thetracingcrate inhyperlight-js-runtime, which was suppressing all log levels above error in release builds.Fixes #126
Changes
release_max_level_errorfrom the tracing crate features inhyperlight-js-runtime/Cargo.tomlProblem
The
release_max_level_errorfeature causes the tracing crate to compile out all trace/debug/info/warn log levels in release builds. This breaks tracing functionality and prevents users from seeing log output at levels other than error.Testing
tests/tracing_features.rswhich usescargo treeto verify the tracing crate's enabled featuresrelease_max_level_erroris NOT present andmax_level_traceIS present