Merged
Conversation
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the npm upgrade step in the npm publishing GitHub Actions workflow to avoid npm’s self-upgrade failure mode during trusted publishing setup.
Changes:
- Replace
npm install -g npm@...with annpx-bootstrapped npm install to avoid the self-upgrade bug. - Expand inline documentation in the workflow explaining the rationale and failure mode being avoided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the npm upgrade step in the GitHub Actions workflow to address a known issue with npm self-upgrades. Instead of using
npm install -g npm@..., the workflow now usesnpxto bootstrap the upgrade process, which avoids a bug that can cause the upgrade to fail.