fix(http1): evict pooled conn on request-side Connection: close - #4110
Open
samlandfried wants to merge 2 commits into
Open
fix(http1): evict pooled conn on request-side Connection: close#4110samlandfried wants to merge 2 commits into
samlandfried wants to merge 2 commits into
Conversation
seanmonstar
reviewed
Jun 23, 2026
| // regardless of the response. | ||
| if head | ||
| .headers | ||
| .get(CONNECTION) |
Member
There was a problem hiding this comment.
This probably needs to get_all, and check them all, either here, or some new headers::connect_any_close() helper.
Author
There was a problem hiding this comment.
@seanmonstar Added a connection_any_close that finds and acts on any Connection: close header
hyper's client derives connection reuse from the response alone, so a request carrying `Connection: close` whose backend response omits it (keeps the socket alive) leaves the connection pooled and reusable. Disable keep-alive at request-encode time when the outgoing request carries a `Connection: close` token so the connection is evicted regardless of the response. Every `Connection` header line is inspected via a `connection_any_close` helper (over `get_all`), not just the first, so a `close` on a later line or within a comma-separated value is honored. Adds a conn-level regression test (client Conn + write_head) asserting a `Connection: close` request disables keep-alive -- including comma-separated and multi-line forms -- while a keep-alive request stays reusable.
samlandfried
force-pushed
the
conn-close-eviction-fix-1x
branch
from
July 28, 2026 18:29
8f242c6 to
f816d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hyper's client derives connection reuse from the response alone, so a request carrying
Connection: closewhose backend response omits it (keeps the socket alive) leaves the connection pooled and reusable.Disable keep-alive at request-encode time when the outgoing request carries
Connection: closeso the connection is evicted regardless of the response.