fix: name what overrides the receiver's loader - #174
Merged
Merged
Conversation
The comment in config/receiver/grpc.yaml said an engine-rendered destinations.loader overrides the default loader address. The engine stopped writing that entry in dfe-engine#441, so it now says what does: an overlay setting loader.grpc_endpoint. Comment only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One comment in config/receiver/grpc.yaml was wrong since dfe-engine#441. It said an engine-rendered destinations.loader overrides the receiver's default loader address. The engine no longer writes that entry, so the comment now names what does: an overlay setting loader.grpc_endpoint.
Comment only, no behaviour change. make check-python check-tests check-docs is green locally (609 tests).
Done when CI is green. Not for merge by this PR's author.