fix(tests): no test run deletes the checkout's generated compose fragment - #173
Merged
Merged
Conversation
…ment Tests that drive resolve_profile.main() redirected .profile.mk but not the instances fragment, so a run on a live checkout deleted its docker-compose.instances.yml (instances.write with nothing to write removes the file). Measured on main d8ee7d1: a planted fragment was gone after make check-tests. An autouse fixture now points both generated files at tmp_path for every test; with it the planted fragment survives unchanged and 609 pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
make check-testson a live checkout deleted its docker-compose.instances.yml. Tests that call resolve_profile.main() redirected .profile.mk but not the instances fragment, and instances.write with nothing to write removes the file.Done when no test run touches a generated file in the checkout.