fix(init): .env is never readable by other users - #171
Merged
Merged
Conversation
.env carries every secret init generates, and every writer opened it under the umask, so a checkout with umask 002 left it 664 -- readable by any local user on the host. All five writers now go through one helper that creates the file at its mode and reasserts it on rewrite: .env at 0640, since a daemon install shares it through the checkout's group, and the backup and access summary at 0600 as before. make init also closes an existing .env to others without touching its owner or group bits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.env holds every secret make init generates, and all five writers opened it under the umask. On the standing devex VM (umask 002) it was 664, so any local user could read the stack's passwords.
make check-python and check-tests: 462 passed. check-docs is clean. Done when a new or upgraded install's .env has no permission bits for others.