fix: stamp the real version into the image and bound CULVERT_CRL_DAYS - #61
Merged
Merged
Conversation
The published image's /etc/vpn/VERSION read "dev" because nothing passed the release version into the Dockerfile's ARG VERSION build arg. hyperi-ci now renders it from release.container.build_args. CULVERT_CRL_DAYS reached Easy-RSA unvalidated, so a zero, negative, or non-numeric value could break CRL regeneration silently. validate() now rejects both cases with a clear error; unset still defaults to 180. Also documents scalo.logger.setup and its four call sites in docs/scalo-reference.md, closing the Quality "no doc did" warning from #60.
Contributor
|
Released in v2.1.17 -- https://github.com/hyperi-io/culvert/releases/tag/v2.1.17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published image's /etc/vpn/VERSION read "dev" because nothing passed the release version into the Dockerfile's ARG VERSION build arg. hyperi-ci now renders it from release.container.build_args, using the {version} placeholder it substitutes at release time.
CULVERT_CRL_DAYS reached Easy-RSA unvalidated, so a zero, negative, or non-numeric value could break CRL regeneration silently. validate() now rejects both cases with a clear error; unset still defaults to 180. crl_days stays a plain int everywhere it's consumed (pki.py, revoke-client.py, update-crl.py); an unparseable raw value is carried separately in crl_days_invalid so validate() can name it.
Also documents scalo.logger.setup and its four call sites in docs/scalo-reference.md, closing the Quality "no doc did" warning from #60.