Repository navigation
Reap orphaned workers without weakening fleet shutdown - #7
Merged
Merged
Conversation
philcunliffe
marked this pull request as ready for review
September 11, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-running loops accumulated thousands of zombies because the Node safety controller ran as PID 1 without reaping adopted worker descendants. Package tini as PID 1 and run the controller as its direct child, retaining whole-container termination when the controller exits or crashes. Reject unmanaged startup and a second external init. LLP 0076 extends the existing PID 1 requirement without changing admission limits or operator holds.
Validation: 295 unit tests and typecheck pass. The local Docker smoke uses fake services and proves orphan reaping, bounded recovery, persistent holds, detached-worker termination, and fail-closed startup. The new orphan check fails against the previous implementation and passes with this change. CPU/memory review found no unbounded polling or allocation added; tini reaps on child exit.
The production fleet remains stopped with automatic restart disabled. This PR does not deploy or restart it.