Repository navigation
6524: Mark functions that no longer work as deprecated - #7
Open
porterhyphenborden wants to merge 2 commits into
Open
porterhyphenborden wants to merge 2 commits into
porterhyphenborden wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates broken functions and updates documentation.
Some functions (search/discover) in this package are broken/calling endpoints that do not exist. The methods of the client
HSClientare almost entirely broken as well (does not correctly handle API responses) so have deprecated that entire thing.To test:
git fetch origingit checkout --track origin/6524-deprecate-broken-functionsRto start R sessioninstall.packages(c("devtools", "remotes"))remotes::install_deps(dependencies = TRUE)devtools::load_all(".")hs_search(text = "test")hs_discover()HSClient$new()Should see the deprecation warning for these 3 calls.
Note: CI checks are failing with:
I am not going to update the actions at this time since we are not planning to develop this currently.