Repository navigation
Reduce repeated lock matrix save checks - #192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The lock-mode matrix repeats the same edit, save, parse and validation sequence four times, although the distinct behavior under test is whether each mode permits insertion, removal and movement.
Solution
Keep the persistence round trip for
contentOnlyand all structural operation checks for all four modes. Forwarding, rendered layout and regeneration coverage stays in place.dev/test/authoring.runtime.test.tscontentOnlyround tripDiff
+13 −11 · 1 test file · no application changes
Testing & verification
Reviewed revision:
0834cfa9879663baae5dccbc3f084c1668037269· Node 22.23.1npm test -- dev/test/authoring.runtime.test.ts: 10 passed.npm run typecheck: passed.git diff --check: passed.Exact-head CI run 38293548692 passed on Node 22.13 and 24, including full verification, package consumers and the WordPress proof job.
Not verified: runtime saving was not measured; the test case count is unchanged.
Risk / rollout
The save round trip no longer covers its cross-product with unlocked, insert and all modes. Their distinct structural checks remain. Detection: retained persistence, forwarding and regeneration assertions. Rollback: revert this test-only commit.