Repository navigation
Trim brittle test assertions and fixture self-checks - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tests asserted documentation wording, hand-written activation fixture labels, release source spellings and exact hook-call bookkeeping. Those checks made harmless edits fail without proving the behavior they described.
Solution
Remove the fixture self-check and two source-only release cases, and trim prose/generated-JavaScript spelling assertions. The generated editor test retains its unique settings-forwarding check; actual rendered layout, save/reopen, locks, hashes, receipt refusal and compiler rejection coverage remain.
dev/test/skill.test.tsdev/test/release-activation-contract.test.tsdev/test/authoring.runtime.test.tsDiff
+17 −213 · 5 files · application source and test configuration unchanged.
Testing & verification
Reviewed revision:
94a3388· Environment: local macOS, Node 22.23.1.vitest run dev/test/skill.test.ts dev/test/release-activation-contract.test.ts dev/test/authoring.generate.test.ts dev/test/authoring.runtime.test.ts --reporter=dot: 42 passed across 4 files, exit 0, 8 seconds.npm run typecheck: exit 0.git diff --check: exit 0.Bounded advisor review identified these brittle families; source review retained the unique emitted-settings check that the rendered helper supplies manually.
Exact-head CI 38283821682: Node22.13/24 full verification passed969/four skips; package and WordPress checks passed. The first utility-hero native-style check failed (9passed/1failed); one bounded failed-job rerun passed without source changes, and the original log is retained.
Not verified: no measured runtime saving is established. Three cases are removed, with larger savings in assertion and fixture maintenance.
Risk / rollout
Release orchestration has fewer literal source-presence checks; these were weak evidence of executed wiring. Documentation copy and hook implementation can change without rewriting these assertions. Actual agent activation remains unproved by the removed fixture labels.
Detection: existing executed behavior and integrity suites plus CI. Rollback: revert this test-only PR; no migration or production operation.