You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix incorrect FSDP configuration examples in the examples/dreambooth/README_flux2.md.
While training, I encountered two issues with the config examples in the README:
The value of fsdp_auto_wrap_policy was incorrect, which caused training to fail.
There was an extra space between the two class names in fsdp_transformer_layer_cls_to_wrap (Flux2TransformerBlock, Flux2SingleTransformerBlock). Removing the space resolved the error.
After correcting both parameters, the training runs successfully.
This PR updates the README with the corrected FSDP configuration examples.
Before submitting
Did you use an AI agent (Claude Code, Codex, Cursor, etc.) to help with this PR? If so:
Note:
Regarding the space between Flux2TransformerBlock and Flux2SingleTransformerBlock in fsdp_transformer_layer_cls_to_wrap: I removed the space because it caused an error in my environment. I'm not sure if this is a general issue or something specific to my setup. Feedback is welcome.
Hi @Thundermean-sky, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked. See the contribution guide for more details. If this PR intentionally does not fix a tracked issue, a maintainer can add the no-issue-needed label to silence this reminder.
Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice.
Once the PR links an issue (or gets the no-issue-needed label), you can ignore this message — it stays here as a comment, but it no longer applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix incorrect FSDP configuration examples in the examples/dreambooth/README_flux2.md.
While training, I encountered two issues with the config examples in the README:
fsdp_auto_wrap_policywas incorrect, which caused training to fail.fsdp_transformer_layer_cls_to_wrap(Flux2TransformerBlock, Flux2SingleTransformerBlock). Removing the space resolved the error.After correcting both parameters, the training runs successfully.
This PR updates the README with the corrected FSDP configuration examples.
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.