Audit every state-changing manager operation - #47
Open
lvwerra wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Manager mutations were only partially attributable: agent-to-agent calls carried
?from=, while operator/UI operations and manager endpoints such as group creation did not. There was also no durable event trail, so creating, changing, moving, or deleting state could not be reconstructed later.This complements #46: its group-creation example now keeps
?from=$AM_ID, and this PR makes that origin meaningful everywhere.What changed
POST,PUT,PATCH, andDELETEunder/api/.?from=$AM_ID)operatororiginremote:<name>id; route-derived fallback keeps existing polling loops workingDATA_DIR/operations.jsonl.GET /api/operations?limit=...&before=...access and document it in the generated environment skill.from=$AM_IDon the notification examples too.Test servers opt into a clearly named missing-origin bypass so existing endpoint-focused fixtures remain scoped to what they test; production never enables it.
Verification
node test/operations.test.mjs— 14 checks covering origin enforcement, operator/agent attribution, group and session creation, with/without-prompt distinction, redaction/hashing, result ids, and query reconstruction.node --check src/operations.jsnode --check src/index.jsnpm run buildinweb/