Repository navigation
Restore support for the bar view on the date and time meters. - #2130
lvaschmidt wants to merge 4 commits into
Conversation
Restore the historical day and year progress calculations and enable bar mode for Clock and Date. Assisted-by: ChatGPT
Assisted-by: ChatGPT Signed-off-by: Lysander Schmidt <me@LysanderSchmidt.com>
I verified this compiles and runs correctly, restores the bar format, and I also corrected the fact that the date meter did not have an assigned color pair in the Black Night theme (which I prefer). So I set it to match the clock color, which I think is a fair guess of the intention of the theme creator. <img width="655" height="83" alt="Screenshot 2026-10-07 at 4 01 41 PM" src="https://github.com/user-attachments/assets/62f8ea43-b39b-4e8c-b1be-beec796ab00e" /> ^The bar meters back to their former glory. <img width="150" height="53" alt="Screenshot 2026-10-07 at 4 02 27 PM" src="https://github.com/user-attachments/assets/610b11f0-071d-498d-a0e0-c32c6c79c900" /> ^The date showing in green (my update to the theme) instead of the probably unintentional blue.
Restore year-progress bar mode, match the Black Night clock color, and use D&T only for the bar caption. Assisted-by: ChatGPT Signed-off-by: Lysander Schmidt <me@LysanderSchmidt.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe clock, date, and date-time meters now support bar mode and expose progress values. Date and date-time totals account for Gregorian leap years. The date-time meter uses Priority: ⬇️ Low Change: Bug fix Merge Risk: ⚪ Minimal · up to Clock, date, and date-time meters now support progress bars, and the Black Night colors match the clock meter. No concrete user-impacting issue remains; the change is ready for normal checks.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. The clock marks minutes through the day Comment |
|
@BenBE and me would generally be in favor of merging this. But: This is AI messy, so please:
|
This overturns a little bit of #1387 , restoring the bar type for Time, Date, and Date & Time meters. This addresses this comment by execvpe, which @BenBE seemed open to?
This change restores those meters to the way they were, reusing the code from before the change, so I wasn't writing new code.
^Here's how they look in my testing of this PR.
One tiny additional change is to fix the oversight in the Black Night theme that failed to label the Date and DateTime meters green the way all similar meters are labeled in that theme.
^The date meters in the corrected color.
I also changed the caption of the date meter in the bar mode to "D&T", which seemed appropriate as far as I could tell.
ChatGPT helped make the PR, and I tested it by hand.