Repository navigation
Clang tidy ci - #89
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 97.19% 98.08% +0.88%
==========================================
Files 80 183 +103
Lines 5132 10006 +4874
==========================================
+ Hits 4988 9814 +4826
- Misses 144 192 +48 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- solvers/ddm.hpp: add explicit `default: break;` to the schwarz_method / krylov_method switches (bugprone-switch-missing-default-case; behavior unchanged, excluded from coverage: no test sets an unhandled method), and take add_infos/set_infos strings by const reference. - solvers/utility.hpp: move LocalLowRankGenerator's shared_ptr sink parameter. - examples/compression_comparison.cpp: reserve vectors before push_back loops (performance-inefficient-vector-operation). - clustering/tree_builder.hpp: compute number_of_children^depth_of_partition as an exact integer instead of comparing against and truncating std::pow's double result. - clustering/partitioning.hpp: use std::distance for iterator offsets stored as int. The solver findings only show with HPDDM available: without it these TUs fail to compile and clang-tidy skips them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- .clang-tidy: every finding is an error except branch-clone (clang-tidy 22 false positive in tree_builder.hpp), exception-escape (only main() in tests/examples) and implicit-widening-of-multiplication-result (defensive int index products); these are still reported. - Disable performance-enum-size: shrinking enums buys nothing here. - narrowing-conversions: ignore conversions from size/difference types and integer -> floating point; htool uses int sizes by design. - ExcludeHeaderFilterRegex needs clang-tidy >= 19, not 17. - CI: run `make tidy` on the ubuntu_clang_openmpi job only (the htool_testing_environments images now ship clang-tidy-19). - Update CHANGELOG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replaces the pre-release commit 27d20aa, whose history was rewritten before the release; v2.4.1 differs in headers only by also silencing -Wold-style-cast in HPDDM.hpp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PierreMarchand20
force-pushed
the
clang-tidy-ci
branch
from
September 29, 2026 09:16
bcc7f16 to
7a9d4ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.