fix: reject --no-bindings with a runtime other than node - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`--no-bindings` was accepted with `--runtime workerd` and did nothing: the bindings proxy is a Node.js thing, and workerd has the real bindings from the wrangler config. The Agent DX team saw `--no-bindings --runtime workerd` return D1 rows and could not tell from the flag name why. The same held for `bun` and `deno` in `request`.
Now `request`, `batch`, and `snapshot` reject `--no-bindings` with any runtime other than `node`, with an `INVALID_OPTION` that says which flag to drop. README updated.
The author should do the following, if applicable
pnpm run format:fix && pnpm run lint:fixto format the code