Repository navigation
Conversation
Take JUnit 6.1.3, Spotless 3.10.4, actions/checkout v7, and actions/setup-java v6. Leave JavaFX 27 on 21.0.6 because it requires JDK 25. Group future minor and patch Dependabot updates.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One PR for the Dependabot bumps that stay on JDK 21 and pass
mvn -B spotless:check test(5 tests, 0 failures) with the current compiler and Surefire plugins. The repository default branch ismaster(there is nomain).Dependabot
groups:now batches future minor and patch updates for Maven and GitHub Actions. Major updates stay as their own PRs.Supersedes
These open Dependabot PRs are covered here. They are left open.
com.diffplug.spotless:spotless-maven-plugin2.43.0 → 3.10.4org.junit.jupiter:junit-jupiter5.11.4 → 6.1.3actions/setup-javav5 → v6actions/checkoutv4 → v7Spotless 3 only requires Java 17. The existing
googleJavaFormat1.23.0 /removeUnusedImportsconfig is unchanged, andspotless:checkis clean. JUnit 6 needs Java 17 and Surefire 3.0.0+; tests use@Testand assertions only, and they pass on Surefire 3.5.2. The workflow usespull_request(notpull_request_target) withdistribution: temurin, so checkout v7 and setup-java v6 are drop-in tag bumps.Left out
org.openjfx:javafx-controls21.0.6 → 27.0.1--release 25and requires JDK 25 or later (JDK-8376601). This repo’s compiler release, CI job, and README are JDK 21. Taking the bump is a JDK migration, not a version-only change.maven-compiler-plugin3.13.0 → 3.16.0maven-surefire-plugin3.5.2 → 3.6.0Test plan
mvn -B spotless:check teston JDK 21 — BUILD SUCCESS, Tests run: 5, Failures: 0, Errors: 0spotless:check, compile, test)