Repository navigation
test(cli): the publish abort test checks the summary hint is absent - #6726
Merged
Merged
Conversation
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 1584b0a7
The new assertion can fail, and the old one couldn't. I made the abort print the summary line alongside the full finding. With the new not.toContain("for full output"), "prints the full finding on a default-entry-mismatch abort even without --lint-verbose" fails. With the old --lint-verbose sentence, it still passed. Both summary hints in lintFormat.ts:93-94 end with "for full output".
Scope
One test line. publish.test.ts passes 20/20 locally. Every Actions run at this head is green, Windows render and tests included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
publish.test.tssays a default-entry-mismatch abort prints the full finding, not the one-line lint summary, and checked it by asserting the summary did not contain "run with --lint-verbose for full output". That sentence stopped existing when the summary began pointing athyperframes lint, so the assertion could no longer fail (review note on the change that did this). It now asserts the output does not contain "for full output", the tail every summary line carries.What I measured
publish.test.tspasses (20 tests).What I did NOT exercise
A failing run of the new assertion: the test's other expectation (the full finding's rule code appears) already fails first if the abort printed the summary, so this line is a second guard, not the only one.
Why under 100 lines
One changed line.
fails without the fix: prints the full finding on a default-entry-mismatch abort even without --lint-verbose