Repository navigation
fix(cli): include external video posters in project archives - #5309
Open
user-github-me wants to merge 4 commits into
Open
user-github-me wants to merge 4 commits into
user-github-me wants to merge 4 commits into
Conversation
Collaborator
|
Thanks for this, @user-github-me. This PR now has merge conflicts with |
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A video poster stored outside the project directory is omitted from a published archive because external-asset localization only inspects
srcandhref. Includeposterin that scan so the image is copied into_ext/and its reference is rewritten relative to the archived HTML file.The current-main integration uses the shared attribute/style resolver and preserves on-disk asset staging for cloud archives. The sharing guide documents external-poster inclusion. Root and nested HTML poster references are covered, including archive contents, relative paths and unchanged source HTML; internal, remote and inline poster references remain covered as well.
Validation: 67 publishing, archive and proxy-baking tests pass. The two tests requiring a live authenticated publishing server remain skipped. CLI build/typecheck, formatting, lint, test reachability, both comment checks, Mint validation/link checks and normal commit hooks pass against the previously built current-main workspace.