ci(studio): gate load, open-project time and eager bundle size - #2944
Draft
miguel-heygen wants to merge 1 commit into
Draft
ci(studio): gate load, open-project time and eager bundle size#2944miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Runs the two-arm load gate on the dev arm at CI budgets against a real 3,000-clip project generated at run time, plus the eager bundle byte check on every studio PR. The bundle check enforces a ratchet at 870,000B rather than the 600KiB target. The target needs a Node-only AST/DOM stack out of the browser bundle, which is its own unit; enforcing it now would mean a permanently red check, and a permanently red check gets muted. The ratchet cannot be regressed past and every run reports the remaining gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 5 of 5 · base
perf/studio-load-u5(#2943)Makes the whole thing a check instead of a one-off measurement. Lands last, and green — a gate wired in red gets muted.
The job
studio-load-gate, gated onneeds.changes.outputs.studiothe same waystudio-timeline-viewportis:NODE_ENV=productionso it measures shipped rendering behaviour, not the development runtime. Evidence uploaded on pass and fail.The bundle budget: target and ratchet
Two numbers, deliberately:
eagerEntryChunkGzipBytes: 600 KiB— the target. Reaching it needs the Node-only AST/DOM stack out of the browser bundle (see perf(studio): defer the source editor and markdown preview off first paint #2943). It is not revised down to match what we happen to ship.eagerEntryChunkGzipRatchetBytes: 870,000— what CI enforces, just above the measured 855,246 B. It may only ever move down.Enforcing an unreached target means a permanently red check, and a permanently red check gets muted — so it would protect nothing. The ratchet locks in the 23.6% already won; every run prints the remaining gap so it stays visible:
Not included
The embedded arm. It needs the CLI studio bundle built, which is materially slower on a hosted runner, and whether that is worth a per-PR check is a runner-cost decision rather than a code one. The dev arm plus the static byte check run on every studio PR; the embedded arm stays a local gate for now. Stated as a limitation rather than presented as full coverage.