Skip to content

Feat/load balancer timeout idle#1394

Draft
mzndr wants to merge 4 commits intomainfrom
feat/load-balancer-timeout-idle
Draft

Feat/load balancer timeout idle#1394
mzndr wants to merge 4 commits intomainfrom
feat/load-balancer-timeout-idle

Conversation

@mzndr
Copy link
Copy Markdown
Member

@mzndr mzndr commented Apr 27, 2026

Add --http-timeout-idle flag to load balancer service commands; adapt describe to display TimeoutIdle for HTTP services.

See the changelog for more information.

@mzndr mzndr requested a review from a team as a code owner April 27, 2026 10:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.85%. Comparing base (cca9beb) to head (c3e7ddf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1394      +/-   ##
==========================================
+ Coverage   72.64%   72.85%   +0.21%     
==========================================
  Files         300      300              
  Lines       11082    11091       +9     
==========================================
+ Hits         8050     8080      +30     
+ Misses       2134     2111      -23     
- Partials      898      900       +2     
Flag Coverage Δ
e2e 51.25% <33.33%> (-0.02%) ⬇️
unit 67.78% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mzndr mzndr self-assigned this Apr 27, 2026
@mzndr mzndr marked this pull request as draft April 27, 2026 11:07
@mzndr mzndr force-pushed the feat/load-balancer-timeout-idle branch 2 times, most recently from c9ee489 to c3e7ddf Compare April 27, 2026 11:59
@phm07
Copy link
Copy Markdown
Contributor

phm07 commented Apr 29, 2026

Looks very good so far! 🙂
One note on the hcloud-go dependency: We usually use a replace directive in the go.mod file. This makes our CI fail so that we know that we still have to merge & release the change in hcloud-go, wait for renovate to update the dependency and then rebase the feature PR.
This command adds the replace directive automatically:

go mod edit -replace github.com/hetznercloud/hcloud-go/v2=github.com/hetznercloud/hcloud-go/v2@<commit-hash> && go mod download

@mzndr mzndr force-pushed the feat/load-balancer-timeout-idle branch from bf8d6b3 to 0a1a63a Compare April 29, 2026 08:35
@mzndr mzndr marked this pull request as ready for review April 29, 2026 08:56
@mzndr mzndr marked this pull request as draft April 29, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants