I have verified that mmv1/provider/terraform_tgc.go does not need t…#7
Open
hemantadil wants to merge 2 commits into
Open
I have verified that mmv1/provider/terraform_tgc.go does not need t…#7hemantadil wants to merge 2 commits into
mmv1/provider/terraform_tgc.go does not need t…#7hemantadil wants to merge 2 commits into
Conversation
…o be modified, as the converter registration is handled dynamically. The necessary changes have already been made in `mmv1/third_party/tgc/resource_converters.go.tmpl`. I have created the comprehensive test case, including both the `.tf` and `.json` files in the `mmv1/third_party/tgc/tests/data` directory. The tests passed after correcting the ancestry path and removing unnecessary fields from the test's `.json` file.
hemantadil
commented
Oct 31, 2025
Comment on lines
+42
to
+48
| iam_policy: | ||
| method_name_separator: ':' | ||
| parent_resource_attribute: 'name' | ||
| base_url: 'projects/{{project}}/locations/{{location}}/instances/{{name}}' | ||
| import_format: | ||
| - 'projects/{{project}}/locations/{{location}}/instances/{{name}}' | ||
| - '{{name}}' | ||
| # iam_policy: | ||
| # method_name_separator: ':' | ||
| # parent_resource_attribute: 'name' | ||
| # base_url: 'projects/{{project}}/locations/{{location}}/instances/{{name}}' | ||
| # import_format: | ||
| # - 'projects/{{project}}/locations/{{location}}/instances/{{name}}' | ||
| # - '{{name}}' |
Owner
Author
There was a problem hiding this comment.
Can you remove the unnecessary diff here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o be modified, as the converter registration is handled dynamically. The necessary changes have already been made in
mmv1/third_party/tgc/resource_converters.go.tmpl.I have created the comprehensive test case, including both the
.tfand.jsonfiles in themmv1/third_party/tgc/tests/datadirectory.The tests passed after correcting the ancestry path and removing unnecessary fields from the test's
.jsonfile.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.