feat: Add converter for logging_organization_sink#3
feat: Add converter for logging_organization_sink#3google-labs-jules[bot] wants to merge 3 commits into
Conversation
This commit adds a new converter to convert `google_logging_organization_sink` Terraform plans to the Cloud Asset Inventory (CAI) format. The converter handles the following fields: - name - destination - filter - description - disabled - exclusions - include_children - bigquery_options
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
| } else if v, ok := d.GetOkExists("include_children"); !tpgresource.IsEmptyValue(reflect.ValueOf(includeChildrenProp)) && (ok || !reflect.DeepEqual(v, includeChildrenProp)) { | ||
| obj["includeChildren"] = includeChildrenProp | ||
| } | ||
|
|
There was a problem hiding this comment.
Done. I've added support for intercept_children and added a test case to validate it.
This commit adds a new converter to convert `google_logging_organization_sink` Terraform plans to the Cloud Asset Inventory (CAI) format. The converter handles the following fields: - name - destination - filter - description - disabled - exclusions - include_children - intercept_children - bigquery_options
| Type: logSinkAssetType, | ||
| Resource: &cai.AssetResource{ | ||
| Version: "v2", | ||
| DiscoveryDocumentURI: "https://logging.googleapis.com/$discovery/rest?version=v2", |
This commit adds a new converter to convert `google_logging_organization_sink` Terraform plans to the Cloud Asset Inventory (CAI) format. The converter handles the following fields: - name - destination - filter - description - disabled - exclusions - include_children - intercept_children - bigquery_options
1 participant
This commit adds a new converter to convert
google_logging_organization_sinkTerraform plans to the Cloud Asset Inventory (CAI) format.
The converter handles the following fields:
PR created automatically by Jules for task 4750095809803742261