feat: add non_blocking support for async fetch dependencies#547
Open
Clement-Hue wants to merge 1 commit intoharrisoncramer:developfrom
Open
feat: add non_blocking support for async fetch dependencies#547Clement-Hue wants to merge 1 commit intoharrisoncramer:developfrom
Clement-Hue wants to merge 1 commit intoharrisoncramer:developfrom
Conversation
Allow dependencies marked as `non_blocking` to continue the fetch chain even on error, preventing a single failing request from blocking subsequent API calls. Applied to the `draft_notes` dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This MR adds
non_blockingsupport to the async fetch pipeline, allowing certain API dependencies to continue fetching subsequent dependencies even if they fail. Thedraft_notesdependency is marked as non-blocking.Perhaps none should be blocking or even fetch in parallel?
Problem
When fetching
draft_notesfails (e.g., due to permissions or unsupported GitLab editions), it blocks the entire async dependency chain, preventing all subsequent API calls from completing. This can break the plugin for users whose GitLab instance doesn't support draft notes, and as consequence preventing them to see and toggle the comments section.Changes
lua/gitlab/async.lua: Addednon_blockinglogic — when a dependency is markednon_blocking, anon_errorcallback is created that continues fetching the next dependency instead of halting the chain. This callback is passed tojob.run_job.lua/gitlab/state.lua: Setnon_blocking = trueon thedraft_notesdependency so its failure doesn't block the remaining fetches.