Repository navigation
fix(extension): the app-called fleet routes answer the documented no-fleet-peers absence (#1812) - #1815
Merged
aarontrowbridge merged 1 commit intoOct 17, 2026
Conversation
…fleet-peers absence (#1812) Extend #1768's session-status discipline to the other fleet routes the app calls: /amicode/fleet/sessions (+ ?scope= / ?archived=), grants, creation-target, and peer-home-base only mounted WITH a staged fleet topology, so a no-topology machine (the unarmed hub) served them the generic no-route 404 the panel render gate refuses. createAmicodeService now pre-mounts the documented 404 {ok:false, reason:"no-fleet-peers"} — the exact body session-status serves — for those four routes on EVERY boot, BEFORE the fleet block; whichever staging branch arms re-adds the same route keys with the REAL handlers (server.add is last-wins), so the fleet-data paths are untouched and a topology-bearing boot is byte-identical. /amicode/fleet/status (not app-called) keeps the #391 base no-route 404, preserving the H3 discipline where it still holds. The two fleetless-boot assertions that pinned the old generic shape (sessions) are updated to the new absence contract — the byte-identity invariants are unchanged and still pass: base vs gated, and observation-only-zero-peers vs base, both answer the identical absence. Extension suite: 329 files, 5426 passed, 53 skipped, 0 failed.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1812. The panel render gate's first live catch, fixed.
The gate (wired into the lane's deploy-gate) failed the live plane with 11 unexplained 4xx/5xx: /amicode/fleet/sessions 404'd generically — the route only mounted WITH a fleet topology, while #1768's discipline says the no-fleet case answers the documented {ok:false, reason:no-fleet-peers} absence (session-status did; sessions didn't).
Fix: pre-mount the four app-called conditional GETs (sessions, grants, creation-target, peer-home-base) with the byte-exact session-status absence body; staging that arms re-adds the same keys with the REAL handlers (last-wins Map semantics) — a topology-bearing boot is byte-identical to today. The full nine-route inventory is in the issue notes; the five already-always-on routes are untouched; /amicode/fleet/status deliberately keeps the #391 no-route 404 (not app-called; the H3 guards keep their meaning).
RED→GREEN across all three fleetless boot shapes; real-data paths proven unchanged (both observation-only and premium-staged boots serve through the same handlers); the two assertions pinning the superseded generic-404 contract were updated with the H3 byte-identity invariants preserved. Suite: 329 files, 5426 passed, 0 failed. The panel gate re-run against the live plane is the director's, after the deploy (HITL).