feat: export dist wasm files and package.json - #228
Merged
Conversation
khaledhosny
reviewed
Aug 25, 2026
| } | ||
| }, | ||
| "./dist/*.wasm": "./dist/*.wasm", | ||
| "./package.json": "./package.json" |
Contributor
There was a problem hiding this comment.
I understand .wasm, but what is package.json needed for?
Contributor
Author
There was a problem hiding this comment.
happy to drop it - I have no particular need of it, but added it as I often do in case people need to check the version of the package that is installed, e.g.:
import pkg from 'harfbuzzjs/package.json'
echo(pkg.version)the alternative, should this be needed, is doing strange things to find the directory of the package, and then readFileSync - but of course this is theoretical as I guess no one's asked for this yet!
danielroe
commented
Aug 25, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently esm users can't import individual
wasmfiles - this exposes them so (for example) this documented example continues to work:https://github.com/harfbuzz/harfbuzzjs/blob/main/examples/harfbuzz-subset.example.node.js#L12-L16
(my motivation: I'm trying to prepare a PR to https://github.com/papandreou/subset-font to update to the latest version of
harfbuzzjs, and it needs direct wasm access)