fix(tests): make unit tests build on Windows#94
Open
raykuo998 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for this. I'll take a look when I can and try to pull it in. I don't have a Windows ARM machine to test on other than CI, so I'll try to push this through CI and just make sure it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several Windows compatibility issues in the unit tests that prevented the project from building with llvm-mingw on Windows ARM64.
The production targets (
transcribeandtranscribe-cli) already built successfully, but the test suite used a few POSIX-specific APIs that are unavailable on Windows.Changes
mkstempsusage with a cross-platform implementation.setenvwith the appropriate Windows implementation where necessary.std::filesystem::pathhandling so Windows wide-character paths are passed correctly.Verification
Built successfully on:
Both the library and the complete test suite now build successfully.