Handle SQLite WAL and Journal files (.gitignore and db drop) - #451
Merged
Merged
Conversation
SQLite keeps -wal and -shm files next to the database in WAL mode, and a -journal file in rollback-journal mode, while a connection is open or after a crash. Widen db/*.sqlite to db/*.sqlite* so these are ignored too, along with databases named .sqlite3.
A stale -journal or -wal file left next to a recreated database of the same name can corrupt it (https://www.sqlite.org/howtocorrupt.html). Remove the -journal, -wal and -shm files along with the database file, even if the database file itself is already gone. The database file is removed last, so a failure part-way through never leaves one of these files behind without its database.
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
timriley
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the extra files SQLite keeps next to a database, now that hanami/hanami-db#21 makes WAL the default journal mode.
hanami newwill now ignoredb/*.sqlite*instead ofdb/*.sqlite, so-wal,-shmand-journalfiles aren't committed.hanami db dropremoves those files along with the database. A stale-walor-journalleft next to a recreated database of the same name can corrupt it.Disclosure: I worked with AI to write this. I most likely would've missed this in my work integrating my changes from hanami/hanami-db#21 into hanami/hanami and would've had to fix these issues after the fact.