Skip to content

Do not output an empty <ram:BuyerReference/> tag #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neuged wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Do not output an empty <ram:BuyerReference/> tag #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/secretariat/invoice.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def to_xml(version: 1, validate: true)
trade_agreement = by_version(version, 'ApplicableSupplyChainTradeAgreement', 'ApplicableHeaderTradeAgreement')

xml['ram'].send(trade_agreement) do
if buyer_reference
if buyer_reference.present?
xml['ram'].BuyerReference buyer_reference
end
xml['ram'].SellerTradeParty do
Expand Down
8 changes: 8 additions & 0 deletions test/invoice_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,5 +884,13 @@ def test_invoice_with_quantity_causing_sub_cent_amounts
end
assert_equal [], errors
end

def test_blank_buyer_reference_is_omitted
invoice = make_de_invoice
invoice.buyer_reference = ''
xml = invoice.to_xml(version: 2)

refute_match(/BuyerReference/, xml)
end
end
end