Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
TradeContactas a model allowing us set:together on
TradePartyfor both buyers and sellers.This somewhat conflicts with the prior addition of
TradeParty.person_namewhich already triggers the creation of aram:DefinedTradeContactgroup in the xml. Settingperson_namedirectly is still supported here as an alternative to giving the TradeContact directly, so this is fully backwards compatible.Note also that #54 also allows to add email and phone details, so that might be a different road you might want go, adding the details directly on
TradeParty.This is partial support for the XRechnung CIUS. I will open an issue shortly and link this PR from there.
Any comments appreciated. Please feel free to make any changes you might need. Feel free to reject this as well.